Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drive2ru] Add new bridge #2116

Merged
merged 7 commits into from
May 23, 2021
Merged

[Drive2ru] Add new bridge #2116

merged 7 commits into from
May 23, 2021

Conversation

dotter-ak
Copy link
Contributor

[Drive2ru] Add new bridge

[Drive2ru] Add new bridge
bridges/Drive2ruBridge.php Outdated Show resolved Hide resolved
bridges/Drive2ruBridge.php Outdated Show resolved Hide resolved
@dotter-ak dotter-ak changed the title Create Drive2ruBridge.php [Drive2ru] Add new bridge May 17, 2021
@dotter-ak dotter-ak requested a review from em92 May 18, 2021 11:07
dotter-ak added 2 commits May 18, 2021 17:29
[Drive2ru] Added option to load full post
Copy link
Contributor

@em92 em92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Помимо перечисленных замечаний, надо линты исправить.

FILE: ...ome/runner/work/rss-bridge/rss-bridge/bridges/Drive2ruBridge.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 48 | ERROR | [x] Concat operator must be surrounded by a single
    |       |     space
 52 | ERROR | [x] Whitespace found at end of line

bridges/Drive2ruBridge.php Outdated Show resolved Hide resolved
bridges/Drive2ruBridge.php Outdated Show resolved Hide resolved
@dotter-ak dotter-ak requested a review from em92 May 18, 2021 19:12
@em92 em92 merged commit 37cd071 into RSS-Bridge:master May 23, 2021
@em92
Copy link
Contributor

em92 commented May 23, 2021

Хорошая работа!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants