Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenlyBridge] Add bridge #2129

Merged
merged 19 commits into from
Aug 15, 2021
Merged

[OpenlyBridge] Add bridge #2129

merged 19 commits into from
Aug 15, 2021

Conversation

VerifiedJoseph
Copy link
Contributor

Adds bridge for Openly

bridges/OpenlyBridge.php Outdated Show resolved Hide resolved
bridges/OpenlyBridge.php Outdated Show resolved Hide resolved
@em92
Copy link
Contributor

em92 commented Aug 10, 2021

Please rebase for tests not to show red.
Also please add examples for detectParameters like I did in TelegramBridge:

const TEST_DETECT_PARAMETERS = array(
'https://t.me/s/durov' => array('username' => 'durov'),
'https://t.me/durov' => array('username' => 'durov'),
'http://t.me/durov' => array('username' => 'durov'),
);

$article = getSimpleHTMLDOMCached($url, self::ARTICLE_CACHE_TIMEOUT);
$article = defaultLinkTo($article, $this->getURI());

$article->find('span.lead-text', 0)->outertext = ''; // Remove lead text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Warning: Creating default object from empty value in /var/www/rss-bridge/pr2129/bridges/OpenlyBridge.php on line 228"

https://feed.eugenemolotov.ru/pr2129/?action=display&bridge=Openly&context=By+Region&region=north-america&content=news&format=Html

@em92 em92 merged commit 10c5259 into RSS-Bridge:master Aug 15, 2021
@VerifiedJoseph VerifiedJoseph deleted the OpenlyBridge branch October 4, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants