Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TelegramBridge] Fix issues & add support for location messages #2133

Merged
merged 11 commits into from
Apr 6, 2022
Merged

[TelegramBridge] Fix issues & add support for location messages #2133

merged 11 commits into from
Apr 6, 2022

Conversation

VerifiedJoseph
Copy link
Contributor

@VerifiedJoseph VerifiedJoseph commented May 26, 2021

Fixes sticker, attachment and reply processing.

@VerifiedJoseph VerifiedJoseph changed the title [TelegramBridge] Fix sticker processing [TelegramBridge] Fix sticker & reply processing May 27, 2021
@VerifiedJoseph VerifiedJoseph changed the title [TelegramBridge] Fix sticker & reply processing [TelegramBridge] Fix sticker, attachment & reply processing May 27, 2021
@Bockiii
Copy link
Contributor

Bockiii commented Mar 28, 2022

Pull request artifacts

file last change
Telegram-current-context1 2022-03-28, 18:58:26
Telegram-pr-context1 2022-03-28, 18:58:26

@Bockiii
Copy link
Contributor

Bockiii commented Mar 28, 2022

The example channel looks exactly the same as before :D Do you have an example were I can see the difference?

Screenshots/code would be enough.

If you want you can generate an html view of your example, upload it to www.termpad.com and link the same raw file as in the comment above, then we can see a live-preview

@Bockiii
Copy link
Contributor

Bockiii commented Apr 5, 2022

@VerifiedJoseph do you have an example for a group where the output actually changed?

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Pull request artifacts

file last change
Telegram-current-context1 2022-04-06, 00:18:03
Telegram-pr-context1 2022-04-06, 00:18:03

@VerifiedJoseph
Copy link
Contributor Author

VerifiedJoseph commented Apr 5, 2022

I've created a test channel (https://t.me/s/rssbridge) which has the changes for sticker and attachments. I can't see a way to reply to messages or find an example in another public channel, so I haven't tested that but it worked before.

@Bockiii
Copy link
Contributor

Bockiii commented Apr 5, 2022

I've created a test channel (https://t.me/s/rssbridge) which has the changes for sticker and attachments. I can't see a way to reply to messages or find an example in another public channel, so I haven't tested that but it worked before.

Thanks for the effort!

I can see that attachments dont really work as intended, right? See the third entry (the logo attachment). There is nothing attached to the feed item.

The sticker is just a giant outline.

The video doesnt play.

Are all of those issues of the html-view and work in rss/atom?

@VerifiedJoseph
Copy link
Contributor Author

VerifiedJoseph commented Apr 5, 2022

Stickers are rendered using JavaScript and use a custom file format, so its only possible to get the grey outline image.

File attachments like the logo (https://t.me/rssbridge/3) can only be viewed in full via the app mobile or desktop client.

File attachments in the desktop client:
image

Video playback works for me 👇
image

@VerifiedJoseph VerifiedJoseph changed the title [TelegramBridge] Fix sticker, attachment & reply processing [TelegramBridge] Fix issues & add support location messages Apr 6, 2022
@VerifiedJoseph VerifiedJoseph changed the title [TelegramBridge] Fix issues & add support location messages [TelegramBridge] Fix issues & add support for location messages Apr 6, 2022
@Bockiii
Copy link
Contributor

Bockiii commented Apr 6, 2022

Ah, it seems like there was an issue in my browser yesterday. The video works now.

As for the stickers, its at least an "info" that a sticker was sent :)

So I'm fine with this. merging

@Bockiii Bockiii merged commit d98add2 into RSS-Bridge:master Apr 6, 2022
Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants