Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PicukiBridge] Displays Instagram Posts #2183

Merged
merged 3 commits into from
Jul 20, 2021
Merged

[PicukiBridge] Displays Instagram Posts #2183

merged 3 commits into from
Jul 20, 2021

Conversation

marcus-at-localhost
Copy link
Contributor

An alternative Instagram Bridge

An alternative Instagram Bridge
@dhuschde
Copy link
Contributor

Since Picuki supports it, you should maybe also add Storys...

Copy link
Contributor

@em92 em92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @marcus-at-localhost !
Looks like it works.

Please fix linting (must work on php 5.6) and other review comments.

public function collectData()
{
$html = getSimpleHTMLDOM($this->getURI())
or returnServerError('Could not request Picuki.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this. getSimpleHTMLDom will throw exception.

public function getURI()
{
if (!is_null($this->getInput('u'))) {
return trim(self::URI, '/') . '/profile/' . $this->getInput('u');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have urljoin

}

if (!is_null($this->getInput('h'))) {
return trim(self::URI, '/') . '/tag/' . $this->getInput('h');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same about urljoin

}

if (!is_null($this->getInput('h'))) {
return trim(self::URI, '/') . '/tag/' . $this->getInput('h');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be nice, if example_hash_tag is accepted the same like #example_hash_tag

Comment on lines 85 to 89
if (!is_null($this->getInput('u'))) {
return $this->getInput('u') . ' - Picuki Bridge';
}

return parent::getName();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing for hashtag?)

php 5.6 compat
add `urljoin`
better hashtag handling
@em92
Copy link
Contributor

em92 commented Jul 4, 2021

@em92 em92 merged commit 3448943 into RSS-Bridge:master Jul 20, 2021
@em92
Copy link
Contributor

em92 commented Jul 20, 2021

gj!

@em92
Copy link
Contributor

em92 commented Jul 20, 2021

@marcus-at-localhost any plans to add stories as @dhuschde suggested? If not, I suggest to @dhuschde to make an feature request as an issue.

@marcus-at-localhost
Copy link
Contributor Author

Thanks @em92!
Honestly, I can't find any stories at picuki :)

@marcus-at-localhost marcus-at-localhost deleted the patch-1 branch July 20, 2021 10:36
@dhuschde
Copy link
Contributor

You can find them by going to https://www.picuki.com/profile/zeo_youtube (Or any other person with Stories) and then click on "Stories"

Bildschirmfoto von 2021-07-20 13-45-05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants