[amazonpricebridge] Fixes for subscription items #2205
Conversation
This adds a few more CSS selectors as fallbacks for subscription items. Note that this is tough to test for, since Amazon doesn't return pricing information if the request is made from a different country.
|
@mada199122, could you test this PR? |
|
tried now... "Price: not available at the moment"
|
I see the same in original page.
|
|
What?
Is there a way to try your fix on my instance? |
|
My screenshot is made on my home laptop and I am using Russian ISP. Also my public instance is on Netherlands. I guess you need to deploy RSS-Bridge instance on Italian location and apply this PR (excluding patch that I mentioned here #2205 (comment)) there to check it. |
|
sorry could you explain just a little bit how to apply this PR... that version stil not work...
|
If you pulled it only a few minutes ago, the Feed could still be in the Bridges cache |
|
uhm... the item is this one... https://www.amazon.it/Braun-Cartucce-Ricarica-Confezione-Ricambi/dp/B075RGQGZM on your instance seams to work instead...
|
|
In my tests, I'd noticed that this is hard to test because Amazon hides the price information if you try accessing it from a different country. |
Co-authored-by: Max <msal.coding@gmail.com> Pulled in from RSS-Bridge#2204
|
Can be helpful if I download an HTML of the Italian store from Italy and I attach here? |
|
Yes please. I've been testing against the HTML that I get after I set a PIN on the Amazon UI. (which does seem to work:
|
|
really thanks |
|
Tested this locally, and it works against the HTML you provided:
Let me get you a docker image so you can test this locally. |
|
ok... thanks |
|
It's already built: |
|
@mada199122 Any chance you could test this? |
|
really really sorry I thought to have answered you... Yes it works perfectly that build!!!! |
|
gj @captn3m0 ! |
|
with the last release now I have this response randomly |
|
I checked the HTML at https://www.amazon.it/dp/B07XK7QXS9 and the code should work fine with it.
I see it picked up the product title correctly. @em92 Any suggestions on how to debug this? |
|
I think is something related to Amazon side... when RSS-Bridge does lot of query Amazon server return that... I saw something similar months ago when I was trying to use Huginn... Which user agent do you declare in the query? |
I would modifiy bridge on your instance to save htmls and to save parsed prices. Using file_put_contents. |
This adds a few more CSS selectors as fallbacks for subscription items.
Note that this is tough to test for, since Amazon doesn't return pricing
information if the request is made from a different country.
Fixes #2203