Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Drop php 5.6 and php 7.0 support #2224

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Conversation

em92
Copy link
Contributor

@em92 em92 commented Jul 27, 2021

php 5.6 reached end of life on Dec 31, 2018
php 7.0 reached end of life on Jan 10, 2019
https://www.php.net/eol.php

Closes #863

Reason to drop support is use getenv() without "varname" parameter, that it ised in #2100

TODOs:

  • update composer.lock
  • change array syntax everywhere (array() -> [])

@em92
Copy link
Contributor Author

em92 commented Sep 5, 2021

change array syntax everywhere (array() -> [])

Removing from todo. Looks like long array syntax is introduced in php 5.4, while I was thinking it is introduced in 7.0

@em92
Copy link
Contributor Author

em92 commented Sep 20, 2021

Php 7.0 introduced "??". So it would be good to force use it with lints.
https://stackoverflow.com/questions/53610622/what-does-double-question-mark-operator-mean-in-php

@dvikan
Copy link
Contributor

dvikan commented Nov 28, 2021

Soon, php 7.3 will not be getting anymore security updates[0].

In my opinion we should enforce a minimum of php 7.4 in order to avoid security problems alltogether.

It also makes the life of developers easier when they can use more recent language features such as the ?? operator and strong typing (also on return values).

[0] https://www.php.net/supported-versions.php

@em92 em92 marked this pull request as ready for review December 2, 2021 23:11
@em92
Copy link
Contributor Author

em92 commented Dec 2, 2021

Lets skip those new language features for now.

@em92 em92 merged commit 071fdef into RSS-Bridge:master Dec 2, 2021
@em92 em92 deleted the drop-php-56-70 branch December 2, 2021 23:12
@em92
Copy link
Contributor Author

em92 commented Dec 2, 2021

In my opinion we should enforce a minimum of php 7.4 in order to avoid security problems alltogether.

Lets allow user to use EOL php on their risk.

Offtopic: In my fulltime paid work (Odoo related consultation) some customers are still running ERPs on Python 2 (reached EOL on Jan 1, 2020) or EOL versions of Python 3.

floviolleau pushed a commit to floviolleau/rss-bridge that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security support for PHP 5.6 ended (31.12.2018)
2 participants