Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PcGamerBridge] fix pc gamer, revert to meta tags, get image from meta tag as enclosure, get category tags #2271

Merged
merged 6 commits into from
Oct 19, 2021
Merged

[PcGamerBridge] fix pc gamer, revert to meta tags, get image from meta tag as enclosure, get category tags #2271

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
473104d
revert pc gamer to using meta tags, look for a.article-link on the fr…
mdemoss Sep 20, 2021
e9e3c7e
grab href from element, reset item array with each loop, html entity …
mdemoss Sep 20, 2021
e7744f9
properly surface tags
mdemoss Sep 20, 2021
6c1f86d
remove 2 tags that don't make sense
mdemoss Sep 20, 2021
19b0686
phpcs code style
mdemoss Sep 21, 2021
a60c6ef
phpcs code style
mdemoss Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 18 additions & 28 deletions bridges/PcGamerBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,43 +2,33 @@
class PcGamerBridge extends BridgeAbstract
{
const NAME = 'PC Gamer';
const URI = 'https://www.pcgamer.com/archive/';
const DESCRIPTION = 'PC Gamer Most Read Stories';
const CACHE_TIMEOUT = 3600;
const URI = 'https://www.pcgamer.com/';
const DESCRIPTION = 'PC Gamer is your source for exclusive reviews, demos,
updates and news on all your favorite PC gaming franchises.';
const MAINTAINER = 'IceWreck, mdemoss';

public function collectData()
{
$html = getSimpleHTMLDOMCached($this->getURI(), 300);
$stories = $html->find('ul.basic-list li.day-article');
$i = 0;
// Find induvidual stories in the archive page
$stories = $html->find('a.article-link');
foreach ($stories as $element) {
if($i == 15) break;
$item['uri'] = $element->find('a', 0)->href;
// error_log(print_r($item['uri'], TRUE));
$item = array();
$item['uri'] = $element->href;
$articleHtml = getSimpleHTMLDOMCached($item['uri']);
$item['title'] = $element->find('a', 0)->plaintext;
$item['timestamp'] = strtotime($articleHtml->find('meta[name=pub_date]', 0)->content);
$item['author'] = $articleHtml->find('span.by-author a', 0)->plaintext;

// Get the article content
$articleContents = $articleHtml->find('#article-body', 0);

/*
By default the img src has a link to an error image and then the actual image
is added in by JS. So we replace the error image with the actual full size image
whoose link is in one of the attributes of the img tag
*/
foreach($articleContents->find('img') as $img) {
$imgsrc = $img->getAttribute('data-original-mos');
// error_log($imgsrc);
$img->src = $imgsrc;
}

$item['content'] = $articleContents;
// Relying on meta tags ought to be more reliable.
$item['title'] = $articleHtml->find('meta[name=parsely-title]', 0)->content;
$item['content'] = html_entity_decode($articleHtml->find('meta[name=description]', 0)->content);
$item['author'] = $articleHtml->find('meta[name=parsely-author]', 0)->content;
$item['enclosures'][] = $articleHtml->find('meta[name=parsely-image-url]', 0)->content;
/* I don't know why every article has two extra tags, but because
one matches another common tag, "guide," it needs to be removed. */
$item['categories'] = array_diff(
explode(',', $articleHtml->find('meta[name=parsely-tags]', 0)->content),
array('van_buying_guide_progressive', 'serversidehawk')
);
$item['timestamp'] = strtotime($articleHtml->find('meta[name=pub_date]', 0)->content);
$this->items[] = $item;
$i++;
}
}
}