New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PhoronixBridge] support multipage and embed benchmarks #2522
Conversation
You can ignore the linting error about donnonsbridge, there was an error in merging another PR. You dont have linting errors with your bridge. |
I ran phpcs prior to submitting. I had one puzzling situation, with the |
|
||
public function collectData(){ | ||
$this->collectExpandableDatas('https://www.phoronix.com/rss.php', 15); | ||
$this->collectExpandableDatas('https://www.phoronix.com/rss.php', $this->getInput('n')); | ||
} | ||
|
||
protected function parseItem($newsItem){ | ||
$item = parent::parseItem($newsItem); | ||
// $articlePage gets the entire page's contents | ||
$articlePage = getSimpleHTMLDOM($newsItem->link); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$articlePage = getSimpleHTMLDOM($newsItem->link); | |
$articlePage = getSimpleHTMLDOM($newsItem->link); | |
$articlePage = defaultLinkTo($articlePage, $this->getURI()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultLinkTo description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review and the suggestion. I didn't notice this because TT-RSS was doing the job itself…
🤖 Pull request artifacts
|
LGTM, thanks! |
The bridge now supports multipage article. In those article, benchmarks from OpenBenchmarking.com are now embedded, either as SVG in
<object>
tag or as<img>
. The second option is useful for feed readers like TT-RSS that disable<object>
or<svg>
tags for security reasons.