Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full rewrite of bridge DeveloppezDotCom #2689

Merged
merged 5 commits into from
May 8, 2022

Conversation

Binnette
Copy link
Contributor

Hello,

I completely rewrote the bridge DeveloppezDotCom. I tested it on my personnal server since 2 weeks and It is working nicely.

I fixed many issues such as:

  1. book announcement are not displayed in current version image
  2. added author with his link image
  3. fixed many encoding issues image
  4. Issues fix coma written as '~?' in the Developpez RSS image
  5. fixed date format of article image
  6. replace not working video iframe by a cute link to the video image
  7. Added an option to limit the number of articles that the bridge should return. Default is 15. image
  8. Added an option to choose between the 134 different RSS proposed by Developpez image
  9. Fully document/comment my code, that way everybody can read it and use it to develop other bridges image
  10. Set myself as the "new" maintainer 🙋
    image

Please review my code and my comments, let me know if there are some stuffs I can improve. Thank you, have a nice day 👍

@github-actions
Copy link

github-actions bot commented Apr 28, 2022

Pull request artifacts

file last change
DeveloppezDotCom-current-context1 2022-05-08, 01:37:25
DeveloppezDotCom-pr-context1 2022-05-08, 01:37:25

@dvikan
Copy link
Contributor

dvikan commented Apr 28, 2022

Don't use array unpacking yet. The limit is not working. I suggest a default limit of 5 because it's slow.

@dvikan
Copy link
Contributor

dvikan commented May 8, 2022

Thanks for your contribution.

@dvikan dvikan merged commit bc773a4 into RSS-Bridge:master May 8, 2022
Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants