refactor: switch to nginx in docker image #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I tried it and it works I think. |
|
Suggestion: |
Alkarex
added a commit
to Alkarex/rss-bridge
that referenced
this pull request
May 30, 2022
RSS-Bridge#2721 introduced a regression by not properly declaring the exposed port in Dockerfile. The Apache version did it correctly: https://github.com/docker-library/php/blob/faf8864e3845ced80780c03eefc66c022e2f9ac1/8.1/buster/apache/Dockerfile#L289 The consequence is that other systems, e.g. Traefik, could not know what port to route to.
Kwbmm
pushed a commit
to Kwbmm/rss-bridge
that referenced
this pull request
Jun 17, 2022
Co-authored-by: Yaman Qalieh <ybq987@gmail.com>
Alkarex
reviewed
Mar 27, 2023
Comment on lines
+4
to
+5
| access_log /var/log/nginx/rssbridge.access.log; | ||
| error_log /var/log/nginx/rssbridge.error.log; |
There was a problem hiding this comment.
Storing logs inside the image is not common for production and is a regression compared to the previous image
#3333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: nginx is better.
Also I (we?) are more familiar with nginx so it becomes easier to introduce a new document root while not breaking BC.
Removed some TLS cruft. They are not used.