Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NACSouthGermanyMediaLibraryBridge] Add new bridge #3636

Merged
merged 13 commits into from Aug 30, 2023

Conversation

R3dError
Copy link
Contributor

@R3dError R3dError commented Aug 26, 2023

Fixes #3635.

Since the items on https://www.nak-sued.de/mediathek/rundfunksendungen-auf-bayern-2/aktuelle-sendungen and https://www.nak-sued.de/mediathek/rundfunksendungen-auf-swr1/aktuelle-sendungen etc. are very spread out, we need to make a considerable amount of web requests. Currently (at the moment of writing this pull request), a call to NACSouthGermanyMediaLibraryBridge::collectData leads to 44 web requests.

@github-actions
Copy link

github-actions bot commented Aug 26, 2023

Pull request artifacts

file last change
NACSouthGermanyMediaLibraryBridge-pr-context1 2023-08-30, 13:57:51

@R3dError
Copy link
Contributor Author

Pull request artifacts

file last change
NACSouthGermanyMediaLibraryBridge-pr-context1 2023-08-26, 16:39:27

Apparently the website is protectecd by CloudFlare. Locally for me, this bridge works fine. Does that mean this cannot be merged?

@dvikan
Copy link
Contributor

dvikan commented Aug 29, 2023

They probably blacklist vps ip ranges. We can merge but maybe add a note in the bridge description about this.

@R3dError
Copy link
Contributor Author

add a note in the bridge description about this.

Done.

@dvikan dvikan merged commit 64000a2 into RSS-Bridge:master Aug 30, 2023
7 checks passed
dvikan pushed a commit to dvikan/rss-bridge that referenced this pull request Sep 13, 2023
* Init nac south bridge

* Rename bridge

* Refactoring

* Refactor

* Fix formatting

* Fix testing errors

* Change constants

* Update logo

* Remove author omission in descriptions

* Fix comment

* Add maintainer

* Rename bridge

* Add technical note to bridge description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge request for the New-Apostolic Church South Germany Media Library
2 participants