Fixed #503 to use most modern version of bridge api and cached pages #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hardly believe the PHP rules prevent non empty lines : PHP is not sensitive to that, it seems to me ... but I'm by no means rss-bridge maintainer)
|
Awesome I can ask myself to do a review! 🤣 Regarding the empty lines: PHP is indeed not sensitive to that. The rules however are to improve code readability rather than code validity. Merged, thanks for the fix! |
|
🤦♂️ Turns out I should have checked more thoroughly. Sorry, I'll push a small fix in a minute.
|
|
I'll change the DOMAIN back to URI, now I know the correct way to have const built from other const instances ... |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
RSS-Bridge#504) Fixed RSS-Bridge#503 to use most modern version of bridge api and cached pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.