Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a bridge for theyetee.com #809

Merged
merged 4 commits into from Sep 10, 2018

Conversation

MonsieurPoutounours
Copy link
Contributor

The bridge fetches daily shirts at theyetee.com.
The Yetee offers two new shirts each day, but you can buy them only for a few hours !
Unfortunately, the site don't provide RSS feed, so the only way to keep up to date on new shirt is their daily mailing ... until now !

The bridge fetches daily shirts at theyetee.com.
The Yetee offers two new shirts each day, but you can buy them only for a few hours !
Unfortunately, the site don't provide RSS feed, so the only way to keep up to date on new shirt is their daily mailing ... until now !
Copy link
Member

@teromene teromene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR ! Small comments.
Please fix the style check (mostly removing " in favor of ', and indentation on empty lines)

bridges/TheYeteeBridge.php Outdated Show resolved Hide resolved
bridges/TheYeteeBridge.php Outdated Show resolved Hide resolved
@MonsieurPoutounours
Copy link
Contributor Author

Added two commits today based on your advice.

@teromene
Copy link
Member

After you fix the style, I'll be able to merge !

@MonsieurPoutounours
Copy link
Contributor Author

So i may misunderstood your instructions :

  • Replacing double quotes for simple ones : done
  • Free line indentation : done
    What i have done wrong ?

@teromene
Copy link
Member

You can check what is wrong by looking at Travis' output here : https://travis-ci.org/RSS-Bridge/rss-bridge/builds/426696079
I'll make a review to help you

bridges/TheYeteeBridge.php Outdated Show resolved Hide resolved
bridges/TheYeteeBridge.php Outdated Show resolved Hide resolved
bridges/TheYeteeBridge.php Outdated Show resolved Hide resolved
bridges/TheYeteeBridge.php Outdated Show resolved Hide resolved
bridges/TheYeteeBridge.php Outdated Show resolved Hide resolved
bridges/TheYeteeBridge.php Outdated Show resolved Hide resolved
@teromene
Copy link
Member

After you did the modifications, you can check whether they are correct by running phpcs . --standard=phpcs.xml --warning-severity=0 --extensions=php -p

@MonsieurPoutounours
Copy link
Contributor Author

Seems good now. Thank you for your help and kindness.

@teromene teromene merged commit 5722a6c into RSS-Bridge:master Sep 10, 2018
@teromene
Copy link
Member

Thank you very much for your patience and for the new bridge !

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
* Adding a bridge for theyetee.com

The bridge fetches daily shirts at theyetee.com.
The Yetee offers two new shirts each day, but you can buy them only for a few hours !
Unfortunately, the site don't provide RSS feed, so the only way to keep up to date on new shirt is their daily mailing ... until now !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants