Use file_get_contents when in CLI mode & no certs #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use file_get_contents when in CLI mode with no root certificates for cUrl. file_get_contents can naively use system root certificates.
|
I've implemented the suggested changes and everything still works. |
|
It would probably be neater if I put all the cUrl stuff in a conditional statement. Would this be ok? |
|
Thanks for the updates! You are right, separating implementation makes sense. The function has become very large, so it needs refactoring in the future, but we'll leave that for another time. Merging now... |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
…dge#962) file_get_contents can natively use system root certificates, so use file_get_contents when in CLI mode with no root certificates for cURL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use file_get_contents when in CLI mode with no root certificates for cUrl. file_get_contents can natively use system root certificates.
Relates to #954