Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BakaUpdatesMangaReleasesBridge] new bridge #999

Merged

Conversation

fulmeek
Copy link
Contributor

@fulmeek fulmeek commented Jan 6, 2019

For people tracking specific releases on mangaupdates.com, this bridge might be useful.

Copy link
Member

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Find below a few comments.

bridges/BakaUpdatesMangaReleasesBridge.php Outdated Show resolved Hide resolved
bridges/BakaUpdatesMangaReleasesBridge.php Outdated Show resolved Hide resolved
bridges/BakaUpdatesMangaReleasesBridge.php Outdated Show resolved Hide resolved
bridges/BakaUpdatesMangaReleasesBridge.php Outdated Show resolved Hide resolved
bridges/BakaUpdatesMangaReleasesBridge.php Outdated Show resolved Hide resolved
@fulmeek
Copy link
Contributor Author

fulmeek commented Jan 9, 2019

Thanks for your suggestions, please see the changes.

Note that the source page is built with an ancient table layout like I would have done it 20 years ago. So, crawling the desired information is a bit quirky.

@logmanoriginal
Copy link
Member

I see what you mean. On the positive end, the bridge is less likely to break if they stay consistent for the next 20 years.

I've added comments to your replies. Let me know if anything is unclear.

logmanoriginal and others added 2 commits January 14, 2019 19:41
Co-Authored-By: fulmeek <36341513+fulmeek@users.noreply.github.com>
Copy link
Contributor Author

@fulmeek fulmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your suggestions, please see the changes.

@logmanoriginal logmanoriginal merged commit 493e76e into RSS-Bridge:master Jan 15, 2019
@logmanoriginal
Copy link
Member

Merged. Thanks again!

@fulmeek fulmeek deleted the BakaUpdatesMangaReleasesBridge branch January 15, 2019 20:27
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants