-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dfs] Add DFS v2.0 #7606
[dfs] Add DFS v2.0 #7606
Conversation
@@ -8,3 +8,19 @@ | |||
*/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#ifndef __UNISTD_H__ | |
#define __UNISTD_H__ |
来个approval…… @mysterywolf @Guozhanxin |
unsigned long rwflag, | ||
const void *data) | ||
static int dfs_tmpfs_mount(struct dfs_mnt *mnt, | ||
unsigned long rwflag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code style
superblock->root.type = TMPFS_TYPE_DIR; | ||
rt_list_init(&superblock->root.sibling); | ||
rt_list_init(&superblock->root.subdirs); | ||
superblock->root.name[0] = '/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code style
|
||
return RT_EOK; | ||
} | ||
|
||
int dfs_tmpfs_statfs(struct dfs_filesystem *fs, struct statfs *buf) | ||
int dfs_tmpfs_statfs(struct dfs_mnt *mnt, struct statfs *buf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static原型?
@@ -339,97 +350,23 @@ int dfs_tmpfs_lseek(struct dfs_file *file, off_t offset) | |||
int dfs_tmpfs_close(struct dfs_file *file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原型为什么都不统一?
{ | ||
if (dentry->flags & DENTRY_IS_ALLOCED) | ||
{ | ||
rt_atomic_sub(&(dentry->ref_count), 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
前面上了锁,这后面再用原子操作的意义是啥?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nfs在dfsv2上不能用了?
@@ -43,7 +43,7 @@ int libc_system_init(void) | |||
#endif /* RT_USING_POSIX_STDIO */ | |||
return 0; | |||
} | |||
INIT_COMPONENT_EXPORT(libc_system_init); | |||
INIT_APP_EXPORT(libc_system_init); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个初始化等级是否确认过了,感觉会翻车啊。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是晚了些,也可以在项目上check下,qemu上是可以的
翻车概率极大
…---Original---
From: ***@***.***>
Date: Sat, Jun 10, 2023 21:28 PM
To: ***@***.***>;
Cc: ***@***.***>;
Subject: Re: [RT-Thread/rt-thread] [dfs] Add DFS v2.0 (PR #7606)
@geniusgogo commented on this pull request.
In components/libc/posix/io/stdio/libc.c:
> @@ -43,7 +43,7 @@ int libc_system_init(void) #endif /* RT_USING_POSIX_STDIO */ return 0; } -INIT_COMPONENT_EXPORT(libc_system_init); +INIT_APP_EXPORT(libc_system_init);
这个初始化等级是否确认过了,感觉会翻车啊。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
{ | ||
if (mnt->fs_ops->lookup) | ||
{ | ||
DLOG(activate, "dentry"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DLOG组件依赖?
拉取/合并请求描述:(PR description)
重新整理DFS v2.0代码,重新提交。
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up