Generate config.h in build directory not in source

[hpwxf]

Generating config.h in source directory is not convenient for multiple builds on the same sources and when updating using VCS

I suggest generating it into the binary directory and to add it to include search path.

[RUrlus]

Hi @hpwxf, happy to make the change regarding the installation on the config header but I want to retain a default version of the header in carma_bits because otherwise the lib is dependent on CMake and not really header only. Someone opened an issue on this a while ago.

[hpwxf]

Ok, I understand.

I could do a workaround where there is default config.h in source. This config.h includes a generated_config.h if it is found. Using something like:

#ifdef __has_include // requires C++17 else do nothing
#  if __has_include("generated_config.h")
#   include "generated_config.h"
#   define USE_GENERATED_CONFIG
# endif
#endif

#ifndef USE_GENERATED_CONFIG

/* default config.h content here */

#endif

What do you think about it?

[hpwxf]

I have updated my PR branch using this idea.

[RUrlus]

Hi @hpwxf, thanks for the updated PR. Sorry, I've been on holiday and haven't been able to pick this up.
I like the idea of the approach but I would prefer to avoid a solution that only works for C++17.

What about setting a definition through CMake and having something like the below in config.h?

#ifdef CARMA_USE_GENERATED_CONFIG
  #include "carma_bits/generated_config.h"
#else
... default config ...
#endif 

[RUrlus]

Ha @hpwxf, I incorporated the above in #94

[hpwxf]

Thank you for

Ha @hpwxf, I incorporated the above in #94

Hi @hpwxf, thanks for the updated PR. Sorry, I've been on holiday and haven't been able to pick this up. I like the idea of the approach but I would prefer to avoid a solution that only works for C++17.

What about setting a definition through CMake and having something like the below in config.h?

#ifdef CARMA_USE_GENERATED_CONFIG
  #include "carma_bits/generated_config.h"
#else
... default config ...
#endif 

Sorry, I was also far far away.
I will check v0.62 as soon as possible.