Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing Obsolete decoration on PageBase #46

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sdl.Web.Common/Interfaces/LegacyContentResolverFacade.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public class LegacyContentResolverFacade : IContentResolver
{
#region IContentResolver Members

[Obsolete("Deprecated in DXA 1.1.")]
public string DefaultExtensionLessPageName
{
get
Expand All @@ -25,6 +26,7 @@ public string DefaultExtensionLessPageName
}
}

[Obsolete("Deprecated in DXA 1.1.")]
public string DefaultPageName
{
get
Expand All @@ -37,6 +39,7 @@ public string DefaultPageName
}
}

[Obsolete("Deprecated in DXA 1.1.")]
public string DefaultExtension
{
get
Expand All @@ -57,6 +60,7 @@ public string ResolveLink(object linkData, object resolveInstruction = null)
return SiteConfiguration.LinkResolver.ResolveLink((string) linkData, localization: contextLocalization);
}

[Obsolete("Deprecated in DXA 1.1.")]
public object ResolveContent(object content, object resolveInstruction = null)
{
throw new NotSupportedException("ResolveContent is not supported in DXA 1.1.");
Expand Down
1 change: 1 addition & 0 deletions Sdl.Web.Common/Models/Legacy/PageBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public abstract class PageBase : ViewModel, IPage
/// Gets or sets the identifier for the Page.
/// </summary>
[SemanticProperty(IgnoreMapping = true)]
[Obsolete("Deprecated in DXA 1.1. Use PageModel constructor to set Id instead.")]
public string Id
{
get
Expand Down
1 change: 1 addition & 0 deletions Sdl.Web.Common/Models/Legacy/Region.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public abstract class Region : ViewModel, IRegion
/// <summary>
/// Gets or sets the name of the Region.
/// </summary>
[Obsolete("Deprecated in DXA 1.1.")]
public string Name
{
get
Expand Down