Open Modelica PR #1378
Merged
Open Modelica PR #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulicModules.Example.Pump´ Changes start input for pump to 1 rpm to avoid mass flow rate = 0 For #1346
…Modules.Example.ThrottlePump´ For #1346
…n-open-modelica 1361 dpcontrolledmovers fail in open modelica
…bility_of_ExergyMeter issue1340_OpenModelica compatibility for ExergyMeter
…yExchnagerOM Issue1351 membrane based enthalpy exchnager om
… changed critical damping to order 1 For #1368
[skip-ci]
…openmodelica #1372 heatingRod OpenModelica
Also they are incorrect, since the head is delayed by 60 seconds but the on-Signal of the pump is not delayed. For #1368
…t in DHC models. For #1352. [skip-ci]
…openmodelica' into Issue1349_reducedorder_fails_in_openmodelica
Issue1368 pump polynomial based om
LauraMaier
reviewed
Nov 22, 2022
LauraMaier
reviewed
Nov 22, 2022
LauraMaier
reviewed
Nov 22, 2022
LauraMaier
reviewed
Nov 22, 2022
LauraMaier
reviewed
Nov 22, 2022
LauraMaier
reviewed
Nov 22, 2022
AixLib/ThermalZones/ReducedOrder/Multizone/BaseClasses/MultizonePostProcessing.mo
Show resolved
Hide resolved
LauraMaier
reviewed
Nov 22, 2022
AixLib/ThermalZones/ReducedOrder/SolarGain/CorrectionGDoublePane.mo
Outdated
Show resolved
Hide resolved
LauraMaier
reviewed
Nov 22, 2022
AixLib/ThermalZones/ReducedOrder/Windows/Validation/SelfShadowing/SelfShadowingTestAbove.mo
Show resolved
Hide resolved
LauraMaier
reviewed
Nov 22, 2022
AixLib/ThermalZones/ReducedOrder/Windows/Validation/SelfShadowing/SelfShadowingTestBelow.mo
Show resolved
Hide resolved
LauraMaier
reviewed
Nov 22, 2022
AixLib/ThermalZones/ReducedOrder/Windows/Validation/SelfShadowing/SelfShadowingTestLeft.mo
Show resolved
Hide resolved
LauraMaier
requested changes
Nov 22, 2022
AixLib/ThermalZones/ReducedOrder/Windows/Validation/SelfShadowing/SelfShadowingTestRight.mo
Show resolved
Hide resolved
AixLib/ThermalZones/ReducedOrder/Windows/Validation/VDI2078/TestCase1_Illumination.mo
Show resolved
Hide resolved
FWuellhorst
commented
Dec 6, 2022
AixLib/ThermalZones/ReducedOrder/Windows/Validation/BaseClasses/IncidenceAngleVDI6007.mo
Show resolved
Hide resolved
|
@LauraMaier : I added all changes or commented my concerns. Please re-review :) |
LauraMaier
requested changes
Jan 30, 2023
...enceResults/Dymola/AixLib_Fluid_Movers_PumpsPolynomialBased_Examples_PumpSpeedControlled.txt
Outdated
Show resolved
Hide resolved
...eResults/Dymola/AixLib_Fluid_Movers_PumpsPolynomialBased_Examples_PumpSpeedControlledDpV.txt
Outdated
Show resolved
Hide resolved
|
Thanks for the nice work, only minor changes from my side. And please make sure the changes in the bin directory are intended :) |
|
@LauraMaier : I resolved all open issues. Please check again :) |
LauraMaier
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundling all changes, we can check CI only once.