Implement numpy hack in setup.py to enable install under Poetry #3363
Conversation
|
Thanks! Let's wait for @mpenkov 's review and we can merge. |
|
Btw I literally just copied the first fix I googled for haha, no idea if there's a more elegant way to do it, or really what any of the |
|
Also will resolve #3225 |
|
Hi Team, We also facing an issue with this: without this fix, gensim cannot be installed via poetry 1.2. Appreciating your help in advance. |
mpenkov
changed the title
setup.py
Outdated
| @@ -104,7 +104,15 @@ def finalize_options(self): | |||
| build_ext.finalize_options(self) | |||
| # Prevent numpy from thinking it is still in its setup process: | |||
| # https://docs.python.org/2/library/__builtin__.html#module-__builtin__ | |||
| __builtins__.__NUMPY_SETUP__ = False | |||
| try: | |||
| __builtins__.__NUMPY_SETUP__ = False | |||
There was a problem hiding this comment.
This particular part appears to be for Python 2 - we don't need it, right?
setup.py
Outdated
| import builtins | ||
| builtins.__NUMPY_SETUP__ = False | ||
| except: | ||
| print("Skipping numpy hack; if installation fails, try installing numpy first") |
There was a problem hiding this comment.
What exception can possibly get raised here?
Assuming that some exception can, then a explicit error message would be better:
| print("Skipping numpy hack; if installation fails, try installing numpy first") | |
| print("Skipping numpy hack; if gensim installation fails, try installing numpy first") |
Also, may as well output the reason why the hack failed (what exception was caught) and a trace.
Implement numpy hack in setup.py to enable install under Poetry piskvorky#3363
this code can never raise an exception, so we shouldn't be expecting them
Fixes #3362
Confirmed poetry install works on M1 mbp with this fix.
poetry add git+ssh://git@github.com:jaymegordo/gensim.git#fix_3362