This repository has been archived by the owner on Dec 22, 2022. It is now read-only.
Feature/variable endpoints #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l to a businessservice is called using its own provided run method, meaning it validates the input.
…r wrapping a ValidationError).
- run debug resultsonly for BusinessServices, - WARNING, API BREAKING CHANGE: changed the run, debug and resultsonly endpoints for "all" to conform to the new endpoints for BusinessServices - added an information/:BusinessService endpoint which provides detailed information for the named BusinessService - the businessservices endpoint now provides a map of businessservices, where the key is the endpoint of the service and the value is the endpoint for information on the service Changed various formatters to account for the presence of specified uitvoer. Made Converter.contextToJson more robust by adding an "isEmpty" check on the context. An empty context returns an empty JsObject.
…debug, but resultsonly.
Simplified the conversion from fact to json so that it now also supports lists. No longer required to mess about with a needlessly complicated map. Was unable to achieve the same level of elegance for a solution for lists from json to facts in the given time. This will need to be brute-forced through the map-solution until a more clever way is devised, but it's impeded progress for too long.
…r result context contains another fact to context, such as with an ElementBerekening.
…and Writes objects and then choke on the fact that they are implicit... This is not a suitable longterm fix, any object that is defined inside another object will now not be considered for Glossary or JsonConversionMap status, possibly hiding otherwise valid implementations...
…ficial develop version 0.0.5-SNAPSHOT.
jhkuperus
reviewed
Feb 3, 2017
| private def contextBedragToJsObject(fact: Fact[Any], factValue: Any): JsObject = factValue match { | ||
| case bedrag: Bedrag => JsObject(Map(fact.name -> Json.toJson[Bedrag](bedrag))) | ||
| case _ => throw new IllegalArgumentException | ||
| private def turnFactsIntoJson(factValue: Any): JsValue = //scalastyle:ignore cyclomatic.complexity |
jhkuperus
approved these changes
Feb 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Adds a bunch of endpoints supporting scala rules BusinessServices including:
Changed various formatters to account for the presence of specified uitvoer.
Made Converter.contextToJson more robust by adding an "isEmpty" check on the context. An empty context returns an empty JsObject.