Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated switch discovery to update lookups #107

Merged
merged 1 commit into from
May 31, 2016

Conversation

SisterMystery
Copy link
Contributor

@SisterMystery SisterMystery commented May 25, 2016

for https://github.com/RackHD/RackHD/issues/236
@RackHD/corecommitters @johren
adds a task to the switch discovery workflow to add all of the switch's interface mac addresses to the lookups collection

depends on RackHD/on-tasks#219

@coveralls
Copy link

coveralls commented May 25, 2016

Coverage Status

Coverage remained the same at 92.224% when pulling cdba754 on VulpesArtificem:snmp-lookups into 180b22d on RackHD:master.

@benbp
Copy link
Contributor

benbp commented May 25, 2016

👍

1 similar comment
@yyscamper
Copy link
Contributor

👍

@benbp
Copy link
Contributor

benbp commented May 25, 2016

test this please

@JenkinsRHD
Copy link
Contributor

*** BUILD #661 ***

@benbp
Copy link
Contributor

benbp commented May 27, 2016

test this please

@JenkinsRHD
Copy link
Contributor

*** BUILD #673 ***
Test Name: Graph Library should validate all existing graphs not requiring user input for null values
Error Details: required option obmServiceName for task Task.Obm.Node.PxeBoot in graph Graph.BootLiveCD
Stack Trace: AssertionError: required option obmServiceName for task Task.Obm.Node.PxeBoot in graph Graph.BootLiveCD
    at AssertService.(anonymous function) [as ok] (node_modules/on-core/lib/common/assert.js:30:28)
    at node_modules/on-core/lib/workflow/task-graph.js:336:20
    at arrayEach (node_modules/lodash/index.js:1289:13)
    at Function.<anonymous> (node_modules/lodash/index.js:3345:13)
    at TaskGraph._validateOptions (node_modules/on-core/lib/workflow/task-graph.js:328:11)
    at node_modules/on-core/lib/workflow/task-graph.js:274:26
    at arrayEach (node_modules/lodash/index.js:1289:13)
    at Function.<anonymous> (node_modules/lodash/index.js:3345:13)
    at node_modules/on-core/lib/workflow/task-graph.js:271:19
    at tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
    at Promise._settlePromises (node_modules/on-core/node_modules/bluebird/js/main/promise.js:697:14)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:123:16)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

@yyscamper
Copy link
Contributor

Jenkins: test this please

@benbp benbp merged commit a5be2d9 into RackHD:master May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants