added a job/tasks to add switch Macs to lookups #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .then(function(snmpData) { | ||
| return _.map(snmpData.data, function(val, key) { | ||
| if (key.startsWith("IF-MIB::ifPhysAddress")) { | ||
| val = _.map(val.split(':'), function(chunk) { |
There was a problem hiding this comment.
A comment on why this is necessary might save future developers from confusion :)
There was a problem hiding this comment.
Yes, put some sample data here will help other developer to understand the code.
|
👍 |
| var self = this; | ||
| return waterline.catalogs.findLatestCatalogOfSource(self.nodeId, 'snmp-1') | ||
| .then(function(snmpData) { | ||
| return _.map(snmpData.data, function(val, key) { |
There was a problem hiding this comment.
How about if catalog 'snmp-1' doesn't exist?
snmpData.data will throw a reference error because snmpData is undefined, but this error is not clear enough for debugging.
|
+1 after comment is fixed. |
|
👍 after @yyscamper's comments as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves https://github.com/RackHD/RackHD/issues/236
@RackHD/corecommitters @johren
Added a job that gets the mac addresses (including management) and adds them to the lookups collection.
supports on RackHD/on-taskgraph#107