[1.2] added a job/tasks to add switch Macs to lookups #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyscamper
changed the title
|
I had some comment in this PR: #219 |
|
👍 after @yyscamper's comments in #219 |
|
@johren is this okay to merge? |
|
Since we are getting ready to cut 1.2.0 today, please hold off. I will give an all clear after that is done. |
|
Release has been cut. This can now go in for next release. Go ahead and merge when ready. |
|
@RackHD/corecommitters |
kellylu2sym
pushed a commit
to kellylu2sym/on-tasks
that referenced
this pull request
Aug 8, 2017
…ress_refine Refine workflow progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves RackHD/RackHD#236
@RackHD/corecommitters @johren
Added a job that gets the mac addresses (including management) and adds them to the lookups collection.
supports RackHD/on-taskgraph#108