Can successfully docker build now, with npm installed in the image

[sirsean]

Resolves: #76

This is solved the dumb way, just by installing npm. I couldn't figure out how to configure project.clj such that npm isn't required to build the jar.

[lvh]

There should be a ticket for having the build container separate from the run container.

[lvh]

This looks good to me assuming CI passes.

[sirsean]

Given that Docker isn't gating in CI I'd be surprised if it failed. ;-p

[lvh]

Hehe, yeah. By "passes" I mean "goes back to failing because of #45".

[codecov-io]

Current coverage is 69.51%

Merging #78 into master will not affect coverage as of d1e4070

@@            master     #78   diff @@
======================================
  Files           15      15       
  Stmts          187     187       
  Branches         3       3       
  Methods          0       0       
======================================
  Hit            130     130       
  Partial          3       3       
  Missed          54      54       

Review entire Coverage Diff as of d1e4070

Powered by Codecov. Updated on successful CI builds.

[lvh]

This looks like it's now fixed. Once you've written the other issue out, I think this is good to go :)