Fixed: Multiple History Issues #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
Fixes multiple issues with history classes as well as some cleanup:
FindDownloadHistorymethod so that it looks for movie history instead of series history when searching for downloaded items.GetBestQualityInHistorymethod to work for movies.This does not remove the series fields from the history model as that would also require a DB migration and it may be best to do one migration for the entire series cleanup from all tables after more of the core is cleaned up.
Todos
Issues Fixed or Closed by this PR
Not sure if this fixes any current github issues?