Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Use APIKey & APIUser for authenticating to PassThePopcorn. #3264

Merged
merged 1 commit into from Dec 30, 2018

Conversation

galli-leo
Copy link
Contributor

Database Migration

NO

Description

Allow users to use APIKey & APIUser. Also deprecated other methods of authenticating.

Todos

  • Tests

Issues Fixed or Closed by this PR

Copy link
Contributor

@onedr0p onedr0p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on my end.

Copy link
Member

@Qstick Qstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, don’t have an account to test the implementation though

@galli-leo galli-leo merged commit 49b1f2a into develop Dec 30, 2018
@onedr0p onedr0p deleted the feature/ptp-apikey branch November 7, 2019 16:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants