Parse Polish language #5592
Merged
Parse Polish language #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some test cases to the language parser unit tests? Let me know if you need help finding the right place. |
|
I've added bunch of test cases |
Qstick
previously approved these changes
Dec 24, 2020
|
Can you rebase? There’s a conflict |
Qstick
added
conflict
|
Fixed |
|
@Qstick mention me if something else needs to be done |
|
Looks fine save for the merge commit, but I can squash it going in. |
|
@tenshiak spoke to soon, you have a trailing white space issue in LanguageParser that is failing backend analysis |
Qstick
removed
conflict
Qstick
previously approved these changes
Dec 29, 2020
As in the title. Almost no-one names their torrent "polish". This PR handles every name I encountered so far.
|
Rebased to remove merge commit and resolve conflict |
Qstick
approved these changes
Dec 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
As in the title. Almost no-one names their torrent "polish".
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR
Fixes nothing.