Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to wrap headers #73

Merged
merged 34 commits into from
Feb 24, 2022
Merged

Add functions to wrap headers #73

merged 34 commits into from
Feb 24, 2022

Conversation

lawruble13
Copy link
Collaborator

No description provided.

@lawruble13 lawruble13 requested a review from cgmb February 10, 2022 21:44
@lawruble13 lawruble13 marked this pull request as ready for review February 11, 2022 17:49
@cgmb
Copy link
Collaborator

cgmb commented Feb 11, 2022

Do you have a branch of rocPRIM or rocBLAS with this integrated?

@lawruble13
Copy link
Collaborator Author

Working on getting both with the latest changes, yes.

@lawruble13
Copy link
Collaborator Author

rocPRIM: https://github.com/lawruble13/rocPRIM/tree/reorg-rocm-cmake

Still needs documentation and a changelog update, but I wanted to start gathering feedback.

@lawruble13 lawruble13 mentioned this pull request Feb 18, 2022
Merged
cgmb
cgmb reviewed Feb 23, 2022
View reviewed changes
share/rocm/cmake/ROCMWrapper.cmake Outdated Show resolved Hide resolved
share/rocm/cmake/ROCMWrapper.cmake Outdated Show resolved Hide resolved
test/libwrapper/CMakeLists.txt Outdated Show resolved Hide resolved
share/rocm/cmake/header_template.h.in Outdated Show resolved Hide resolved
share/rocm/cmake/ROCMWrapper.cmake Outdated Show resolved Hide resolved
share/rocm/cmake/header_template.h.in Outdated Show resolved Hide resolved
arvindcheru
arvindcheru approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@arvindcheru arvindcheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on validation results/updates from new api usages in rocblas, rocprim, All observations are taken care in latest version.
LGTM to get this merged.

cgmb
cgmb approved these changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@cgmb cgmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you've tested the most recent version of your code against one of the existing libraries and you're satisfied with it, then I think it's ready to merge. Nice work, Liam.

@lawruble13 lawruble13 merged commit cbf68ec into ROCm:master Feb 24, 2022
@lawruble13 lawruble13 deleted the wrap-headers branch February 24, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgmb cgmb cgmb approved these changes

@arvindcheru arvindcheru arvindcheru approved these changes

@frepaul frepaul Awaiting requested review from frepaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lawruble13 @cgmb @arvindcheru