Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 2.8.0 #246

Merged
merged 1 commit into from
Jun 20, 2022
Merged

chore: release 2.8.0 #246

merged 1 commit into from
Jun 20, 2022

Conversation

abhiabhi94
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #246 (e36d610) into develop (c68a441) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #246   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files           56       56           
  Lines         1989     1989           
  Branches       288      288           
========================================
  Hits          1987     1987           
  Misses           1        1           
  Partials         1        1           
Impacted Files Coverage Δ
comment/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68a441...e36d610. Read the comment docs.

@abhiabhi94
Copy link
Collaborator Author

build won't pass without merge and release of Radi85/sphinxcontrib-swagger#1.

@abhiabhi94 abhiabhi94 requested a review from Radi85 June 19, 2022 10:56
@Radi85
Copy link
Owner

Radi85 commented Jun 19, 2022

@abhiabhi94 can you please update sphinxcontrib-swagger version?

@abhiabhi94
Copy link
Collaborator Author

@abhiabhi94 can you please update sphinxcontrib-swagger version?

I re-ran the build, it automatically picked up the latest version since that wasn't pinned. 👯 .

@Radi85
Copy link
Owner

Radi85 commented Jun 19, 2022

@abhiabhi94 don't we have a workflow for the main release? 🤔

@abhiabhi94
Copy link
Collaborator Author

@abhiabhi94 don't we have a workflow for the main release? thinking

we used to do a manual release to PyPI, and for test PyPI, they would be made once a tag is pushed on Github.

@Radi85 Radi85 merged commit a753c05 into Radi85:develop Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants