Generators/generic brush editing #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndles multiple times
…rately from the handling the control itself
…rializeable and will not be stored :(
… been selected/deselected
…r with an invalid brush
…ices is not initialized
|
Tested and works well, but not done a code review |
|
As I have been using this branch ever since I started on the source importer I can confirm that it works well. I gave the code a read, looks good. However the public API to create brushes is too convoluted for newcomers. That doesn't have to be addressed in this PR but it's something to keep in mind. This could be mitigated through better naming, more IntelliSense documentation or alternatively a wrapper class that makes common operations easier to prevent them working too low-level. I am barely able to follow the code I wrote myself just to make a box and clip some sides. |
jmickle66666666
approved these changes
Jul 24, 2019
Henry00IS
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for generic brush editing (issue #86)