Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi-character separators #89

Closed
1 task done
duckdotapk opened this issue Nov 28, 2023 · 3 comments · Fixed by #90
Closed
1 task done

Support for multi-character separators #89

duckdotapk opened this issue Nov 28, 2023 · 3 comments · Fixed by #90
Labels
enhancement New feature or request

Comments

@duckdotapk
Copy link

duckdotapk commented Nov 28, 2023

Is there an existing issue for this?

  • I have searched the existing feature requests

Is your feature request related to a problem? Please describe

The application crashes when trying to use a multi-character string as a separator.

I wanted to use "on" as a separator so it says "By Artist on Album".

Describe the solution you'd like

I don't know Rust very much but I can see from a quick search of the code that the application is using a char for the separator. So maybe just change that? I'm not sure if that's easier said than done but just an observation.

Describe alternatives you've considered

No response

Additional context

No response

@duckdotapk duckdotapk added the enhancement New feature or request label Nov 28, 2023
@Radiicall Radiicall linked a pull request Nov 29, 2023 that will close this issue
@Radiicall
Copy link
Owner

You can find binaries for the test version at the bottom of this page when the build is done

@Radiicall
Copy link
Owner

You can find binaries for the test version at the bottom of this page when the build is done

Please let me know if it works

@duckdotapk
Copy link
Author

duckdotapk commented Nov 29, 2023

Seems to work great, thank you for the quick turnaround time :)

Edit: Screenshot!

screenshot

Radiicall added a commit that referenced this issue Nov 29, 2023
allows multicharacter separators in music display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants