-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fast_concat
, generic read
, and from_file
methods to UVCal
#1271
Conversation
fast_concat
, generic read
from_file
methods to UVCalfast_concat
, generic read
, and from_file
methods to UVCal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
========================================
Coverage 99.91% 99.91%
========================================
Files 33 33
Lines 19459 19732 +273
========================================
+ Hits 19443 19716 +273
Misses 16 16
Continue to review full report in Codecov by Sentry.
|
9175258
to
746cd11
Compare
f6ae4f1
to
a1df75d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bhazelton! This is excellent and add lots of nice functionality. Just a few small questions/comments.
a1df75d
to
8671c7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @bhazelton!
Description
Adds the following methods to UVCal:
fast_concat
, similar to the one on UVData.read
, a method that is generic across input file types.from_file
, a class method that allows one-line UVCal object creation from a file.Also deprecates reading multiple files in using file-specific reads (e.g.
read_calfits
) because the handling of combining the objects from multiple files now resides in the genericread
method for less code replication and better maintainability.Motivation and Context
closes #1169
Types of changes
Checklist:
New feature checklist: