Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for recarray UVParameters, needed for pyradiosky #1334

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

bhazelton
Copy link
Member

Description

Add support for UVParameters containing recarrays. This is needed in pyradiosky, see RadioAstronomySoftwareGroup/pyradiosky#126.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1334 (673a74a) into main (6c456ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1334   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          36       36           
  Lines       20015    20045   +30     
=======================================
+ Hits        19999    20029   +30     
  Misses         16       16           
Files Changed Coverage Δ
pyuvdata/parameter.py 100.00% <100.00%> (ø)
pyuvdata/uvbase.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c456ee...673a74a. Read the comment docs.

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup).

Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. But I can't feel like I had a large hand in making it at the same time. maybe @jpober, @steven-murray, or @plaplant want to take a look?

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks reasonable

@bhazelton bhazelton merged commit f703a98 into main Sep 13, 2023
50 of 52 checks passed
@bhazelton bhazelton deleted the recarray_support branch September 13, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants