Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for initializing MirParser from Path objects #1405

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

kartographer
Copy link
Contributor

Description

Added support for using Path objects to initialize MirParser objects in addiion to strings.

Motivation and Context

This was a previously (but not explicitly) supported feature with MirParser class that was integrated into some internal scripts prior to merging of #1371. Because adding support for this was trivial, I've added it back here.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@kartographer kartographer assigned e-koch and unassigned e-koch Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1069b40) 99.92% compared to head (ce5e27e) 99.92%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1405   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          37       37           
  Lines       20766    20767    +1     
=======================================
+ Hits        20750    20751    +1     
  Misses         16       16           
Files Coverage Δ
pyuvdata/uvdata/mir_meta_data.py 100.00% <100.00%> (ø)
pyuvdata/uvdata/mir_parser.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1069b40...ce5e27e. Read the comment docs.

@kartographer kartographer changed the title Adding suppot for initializing MirParser from Path objects Adding support for initializing MirParser from Path objects Feb 20, 2024
@bhazelton bhazelton added UVData SMA Issues related to handling of SMA data labels Feb 20, 2024
@kartographer kartographer merged commit 4398c75 into main Feb 20, 2024
53 of 55 checks passed
@kartographer kartographer deleted the sma_dev branch February 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SMA Issues related to handling of SMA data UVData
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants