-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restartfix #126
Draft
jonathan-beard
wants to merge
13
commits into
master
Choose a base branch
from
restartfix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Restartfix #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e's a condition where the schedule function could still be running in a separate thread on exit, so, we need to make sure the kernels are destroyed after the schedule thread is shutdown
…that or add barrier or soemthing similar to wait on a specific kernel...or even make a new exe forrestart
…roper barrier, wanna re-organize a few things before then though.
… destructed before we're ready, need to check destructor chain from top level graph
…async free issue, sched thread is still inside the graph when terminate is called, will fix tomorrow
… map restart now that the basics work again
Remove Linux only header added for debugging
…o add test cases as well with the actual restart cases. We also likely need to add some way to nicely add new input params to graph every time we restart it in a loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable restarting of streams.
Fixes #98
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Details
Please list details of the configurations of above local tests, specifically
relevant run details.
Please list test cases created to ensure your feature or addition
works.
Checklist: