Handle escaping before executing a task on server

[#99887000]
Ragnarson · Aug 31, 2015 · 462d18a · 462d18a
1 parent 1991de5
commit 462d18a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 ## master
 
+* [improvement] shelly rake accepts rake arguments and properly escapes whitespaces
 * [bugfix] Display proper error for shelly files commands depending on resource
 
 ## 0.5.5 / 2015-03-16

diff --git a/lib/shelly/app.rb b/lib/shelly/app.rb
@@ -238,7 +238,7 @@ def delete_endpoint(uuid)
     end
 
     def rake(task, server = nil)
-      ssh(:command => "rake_runner \"#{task}\"", :server => server)
+      ssh(:command => "rake_runner '#{task.inspect}'", :server => server)
     end
 
     def dbconsole

diff --git a/spec/shelly/app_spec.rb b/spec/shelly/app_spec.rb
@@ -426,7 +426,7 @@ def config_response
     it "should return result of rake task" do
       @client.stub(:tunnel).and_return(
         {"host" => "console.example.com", "port" => "40010", "user" => "foo"})
-      @app.should_receive(:childprocess).with("ssh -o StrictHostKeyChecking=no -p 40010 -l foo -t -t console.example.com rake_runner \"test\"")
+      @app.should_receive(:childprocess).with("ssh -o StrictHostKeyChecking=no -p 40010 -l foo -t -t console.example.com rake_runner '\"test\"'")
       @app.rake("test")
     end