Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored SPI support #175

Merged
merged 5 commits into from
Apr 16, 2021
Merged

Refactored SPI support #175

merged 5 commits into from
Apr 16, 2021

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Apr 10, 2021

Hi, this is still a work-in-progress, but wanted to get some early feedback, if you have some time.

Rahix
Rahix reviewed Apr 10, 2021
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

I took a quick look and left a few comments. Overall it's already looking quite good, thanks for working on this!

avr-hal-generic/src/spi.rs Outdated Show resolved Hide resolved
avr-hal-generic/src/spi.rs Outdated Show resolved Hide resolved
avr-hal-generic/src/spi.rs Outdated Show resolved Hide resolved
@Rahix Rahix changed the title wip Refactored SPI support Apr 10, 2021
Rahix
Rahix reviewed Apr 12, 2021
View reviewed changes
avr-hal-generic/src/spi.rs Outdated Show resolved Hide resolved
@drmorr0
Copy link
Contributor Author

drmorr0 commented Apr 16, 2021

I only have an uno and a nano, so I can't test this on other boards, but I just copied what was already there in master and the type-checking all worked out. I think this is ready to go? Let me know if you have other feedback.

@drmorr0 drmorr0 marked this pull request as ready for review April 16, 2021 03:20
Rahix
Rahix approved these changes Apr 16, 2021
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Don't worry too much about breaking anything, we'll fix it when the bug reports come in - that's the nice thing about experimental software ;)

@Rahix Rahix merged commit 03da962 into Rahix:next Apr 16, 2021
@Rahix Rahix mentioned this pull request Apr 19, 2021
Open
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drmorr0 @Rahix