Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feather basic #224

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feather basic #224

wants to merge 4 commits into from

Conversation

gauteh
Copy link
Contributor

@gauteh gauteh commented Oct 5, 2021

  • feather 32u4: add board hal
  • feather-32u4: set up blink example

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR!

I've left a few comments inline with the diff. Additionally, I think we should try to use more consistent naming: In some places you refer to the board as feather-32u4, in others you call it feather-32u4-basic. Unless there are other "Feather with ATmega32U4" boards out there, I'd just choose the shorter name everywhere?

examples/feather-32u4-basic/.cargo/config.toml Outdated Show resolved Hide resolved
arduino-hal/src/port/feather_32u4.rs Outdated Show resolved Hide resolved
@gauteh
Copy link
Contributor Author

gauteh commented Oct 12, 2021

In some places you refer to the board as feather-32u4, in others you call it feather-32u4-basic. Unless there are other "Feather with ATmega32U4" boards out there, I'd just choose the shorter name everywhere?

There are several editions, much in common:

  • basic
  • bluefruit LE
  • adalogger
  • lora
  • FONA

I only have the basic. Not sure if anyone still buys these.

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several editions, much in common:

Alright, then let's go with feather-32u4-basic everywhere.

# Flashing

```sh
$ avrdude -v -p m32u4 -cavr109 -P /dev/ttyACM0 -D -Uflash:w:target/avr-atmega32u4/release/sby-buoy-feather.elf:e
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use the path to one of the actual example binaries here, to reduce confusion.

Suggested change
$ avrdude -v -p m32u4 -cavr109 -P /dev/ttyACM0 -D -Uflash:w:target/avr-atmega32u4/release/sby-buoy-feather.elf:e
$ cargo build --bin feather-blink
$ avrdude -v -p m32u4 -cavr109 -P /dev/ttyACM0 -D -Uflash:w:../../target/avr-atmega32u4/debug/feather-blink.elf:e

(untested)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants