Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add support for Atmega8 #368

Closed
wants to merge 2 commits into from
Closed

Draft: Add support for Atmega8 #368

wants to merge 2 commits into from

Conversation

xfmoulet
Copy link

based on PR #306

closes #363

@xfmoulet
Copy link
Author

I have an issue (so closing this PR for the moment) : adps().prescaler_2 does not exist only bit definitions ...
I try to find a way to temporarily disable the ADC device for the moment (I guess the other possibility would be to enable is automated extraction in avr-device ?)

@xfmoulet xfmoulet closed this Nov 22, 2022
@Rahix
Copy link
Owner

Rahix commented Nov 22, 2022

Let's keep the PR open while you're still working on it. Closing a PR usually means abandoning the work which probably isn't what you intend to do ;) You can mark the PR as a draft if you feel more comfortable with that, but it's fine for me either way.

@Rahix Rahix reopened this Nov 22, 2022
@Rahix
Copy link
Owner

Rahix commented Nov 22, 2022

@xfmoulet, for your ADC problem, maybe we just need to apply the proper patches to the register definitions in avr-device? Maybe you can cross-check the registers in the datasheet of the ATmega8 with the ATmega328P. If they are the same, we just need to apply the same patches as for ATmega328P for the ATmega8. Those would be https://github.com/Rahix/avr-device/blob/main/patch/common/adc.yaml.

@xfmoulet xfmoulet changed the title Add support for Atmega8 Draft: Add support for Atmega8 Nov 22, 2022
@Rahix Rahix marked this pull request as draft November 23, 2022 00:09
@Rahix Rahix mentioned this pull request Jan 5, 2023
@Rahix
Copy link
Owner

Rahix commented Jan 5, 2023

Closing per #363 (comment) in favor of #384.

@Rahix Rahix closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of Atmega8
2 participants