Allow glitchless output configuration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring a pin as output, it was previously not possible to glitchlessly bring the pin into the desired electrical state. Change the semantics of `into_output()` such that it always puts the pin into a LOW state. Add a new `into_output_high()` which always puts the pin into a HIGH state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring a pin as output, it was previously not possible to glitchlessly bring the pin into the desired electrical state. For lots of control usecases, this is a very important feature.
Change the semantics of
into_output()such that it always puts the pin into a LOW state. Add a newinto_output_high()which always puts the pin into a HIGH state.I am going to mark this as a breaking change because existing code might rely on the fact that
into_output()previously didn't touch the pin state...