Correctly synchronize UI and other threads when opening a SX popup. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #229.
When a script is saved and has incomplete strings, then an empty popup appears which should contain a message and buttons. This happens because the UI related code is not executed inside the UI dispatcher thread and the UI dispatcher thread itself is blocked inside the while loop right after opening the popup. This also means that all popups created from the SX class are flawed.
This PR corrects the synchronization with the UI dispatcher thread. Opening a popup now works from within the UI dispatcher and other threads. It also properly implements focusing the password field.