Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly synchronize UI and other threads when opening a SX popup. #230

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@balmma
Copy link
Contributor

balmma commented Nov 16, 2019

Solves issue #229.

When a script is saved and has incomplete strings, then an empty popup appears which should contain a message and buttons. This happens because the UI related code is not executed inside the UI dispatcher thread and the UI dispatcher thread itself is blocked inside the while loop right after opening the popup. This also means that all popups created from the SX class are flawed.

This PR corrects the synchronization with the UI dispatcher thread. Opening a popup now works from within the UI dispatcher and other threads. It also properly implements focusing the password field.

@balmma

This comment has been minimized.

Copy link
Contributor Author

balmma commented Nov 16, 2019

@RaiMan
IMO it would make sense to cherry pick this to branch release_2.0.x.

@RaiMan RaiMan merged commit 69d5693 into RaiMan:master Nov 18, 2019
@balmma balmma deleted the SKOORAG:popup_ui_thread branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.