Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUID of target_users do not match the [uid] values embedded via the email template #24

Closed
cobbr opened this issue Jan 9, 2017 · 7 comments

Comments

@cobbr
Copy link

cobbr commented Jan 9, 2017

Is the [uid] value that gets placed into each email from the email template stored anywhere in the backend database? It doesn't appear to match the UUID value of the corresponding target_user.

It would be useful for tracking link clicks to be able to access this value externally from FiercePhish. I don't mind implementing this behavior myself, I just wanted to be sure that I'm not missing something.

@Raikia
Copy link
Owner

Raikia commented Jan 9, 2017

Right, so this is something that is already in the process of being fixed. The UUID of a user is not the same as the UUID sent in an email. It changes per campaign. So the UUID of the target user is not actually sent in an email, its used in combination with the campaign_id to generate a new UUID. Look at your campaign details and you will see the actual uuids sent and which user it corresponds to.

But yes, I am planning on changing how this is being saved for easier understanding.

@Raikia
Copy link
Owner

Raikia commented Jan 9, 2017

To answer your question: No, the uuid used in the email is not currently stored in the database. But that will change in the dev branch within the next 24-48 hours :-)

@cobbr
Copy link
Author

cobbr commented Jan 9, 2017

Awesome! Thanks for the quick response. So, just to be clear, you are changing the behavior to use the target_user UUID in the email, or adding a UID field for emails in the database?

@Raikia
Copy link
Owner

Raikia commented Jan 9, 2017

There will be a UID field in the "emails" table. I think its important to have a different UUID for each user for each campaign (so the same user doesn't get the same UUID in later emails)

@Raikia
Copy link
Owner

Raikia commented Jan 10, 2017

The dev branch now has the UUID changes you requested. It will be merged in to master after testing.

@cobbr
Copy link
Author

cobbr commented Jan 10, 2017

Thanks!

@Raikia
Copy link
Owner

Raikia commented Jan 11, 2017

Completed, committed, and merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants