Add limit for event #479
Merged
Add limit for event #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpraglowski what's the purpose of this? |
|
It seems like UUID string limit... for MySQL? |
Exactly that |
mpraglowski
force-pushed
the
add-limit-for-event-id
branch
from
347f3ce
to
7e4a05f
Compare
...cord/lib/rails_event_store_active_record/generators/templates/limit_for_event_id_template.rb
Show resolved
Hide resolved
mpraglowski
force-pushed
the
add-limit-for-event-id
branch
3 times, most recently
from
a3c5b3f
to
53c1dec
Compare
…sion - we explicitly use ActiveRecord::Migration[4.2] in generated migrations - in fill_data.rb ActiveRecord::Schema.define assumes always version of current Rails/ActiveRecord - since Rails 5.1 the default behaviour of unspecifed id column has changed and bigint is used (serial was integer) - without a chance to pass desired migration version AR:S.define, use overly specific id: :integer https://github.com/rails/rails/blob/9ae3ddbb21ece10550c8fd37e0c12bab9f5a89f8/activerecord/lib/active_record/migration/compatibility.rb Consider RailsEventStore#208 as an alternative solution (while also adding additional tests to check DSL behaviour drift across Rails versions).
Only Rails 4.x vs 5.x supported for now.
No limit on uuids.
Solves indeterministic issues with schema cache and tables visibility. Forked processes inherit file descriptors so closing connection before fork could and re-opening right after could make sense.
mostlyobvious
force-pushed
the
add-limit-for-event-id
branch
from
53c1dec
to
812ea7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.