JSON Support in ROM Adapter #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecord compatiblitiy when using JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated migrations to allow specifying JSON or JSONB for
dataandmetadata. This required some updating of ROM schema types and also cleaning up the test data uses forSerializedRecord. The test data in RSpec tests worked as arbitrary strings with YAML but not JSON (e.g. a UUID string can be deserialized by YAML but needs quotes in JSON). Minor changes to make the data compatible with both YAML and JSON was sufficient since tests use serialized data rather than a specific RES serializer.