resolve issues #342 & #362 make indexed things searchable #363
Conversation
finanalyst
commented
Apr 20, 2024
finanalyst
commented
- previous default was not to make them searchable (because too many things were duplicated)
- the duplicates have now been reduced.
- users who have used the site before will need to remove the localstorage to over-ride the previous default.
- previous default was not to make them searchable (because too many things were duplicated) - the duplicates have now been reduced. - users who have used the site before will need to remove the localstorage to over-ride the previous default.
|
Can we write some JS to wipe the setting the first time we check it? Maybe keep a dumb id of the version of JS expected - with the new version - set it to 1 and go up each deployment; if we check it and it's 0, fix it so the default isn't in place. Also: we shouldn't be saving the default value explicitly - it should be a default if not set. then we can change what the default setting is without having to jump through hoops and only worry if someone changed it explicitly. (in which case we can override it with certain releases) |
This is true and I hadn't considered this. Let me think about this for a bit. |
|
@coke fixed the default issue. Actually an easy fix. So options only stored when there is a change from the default. |
There was a problem hiding this comment.
Looks like this should improve things, but doesn't deal with the case where someone already has an override.
We probably want to add a button to the settings page where someone can reset and get things back to the current defaults, regardless of how they interacted in the past
|
I'll add that to the options popup.
…On Tue, 30 Apr 2024, 14:58 Will Coleda, ***@***.***> wrote:
***@***.**** approved this pull request.
Looks like this should improve things, but doesn't deal with the case
where someone already has the defaults.
We probably want to add a button to the settings page where someone can
reset and get things back to the *current* defaults, regardless of how
they interacted in the past
—
Reply to this email directly, view it on GitHub
<#363 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACYZHG3AJYG2URGFDWYUELY76PPRAVCNFSM6AAAAABGQX25D2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZRGQ2TSNJSGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
