make More->announcements less like link #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
finanalyst
commented
May 13, 2024
finanalyst
commented
- change colour of text
- make hover over background consistent
- green is not intutive for 'suppressed', so change to another pallet colour
- tweaks to placing of 'ball' & text
- remove redundant CSS (.original)
- change colour of text - make hover over background consistent - green is not intutive for 'suppressed', so change to another pallet colour - tweaks to placing of 'ball' & text - remove redundant CSS (.original)
|
@coke will deploy soon on new-raku |
|
@coke some more tweaks needed |
|
@coke you can see the change in new-raku More->announcements |
|
I really don't see any difference between the two. |
|
I launched them both (prod & your site), opened the inspector, and the computed CSS on the text was even the same. |
|
The change is the colour of the 'ball' when 'supressed'. The background
matches the other item in the drop-down, and the background changes when
the mouse hovers.
…On Tue, 14 May 2024, 01:35 Will Coleda, ***@***.***> wrote:
I launched them both (prod & your site), opened the inspector, and the
computed CSS on the text was even the same.
—
Reply to this email directly, view it on GitHub
<#381 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACYZHCF7HQZBBOQ422PGBTZCFL5BAVCNFSM6AAAAABHURDI42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZGA2TMNRXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Oh, I thought it was in the popup itself! Yes, definitely see this, looks much better. |
coke
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.