Disambiguate PERL6LIB in search with categories #3200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJ
requested changes
Feb 5, 2020
| @@ -1509,7 +1509,7 @@ Perl modules is C<PERL5LIB>. | |||
| $ PERL5LIB="/some/module/lib" perl program.pl | |||
|
|
|||
| In Raku this is similar, one merely needs to change a number! As you | |||
| probably guessed, you just need to use X<C<PERL6LIB>|PERL6LIB>: | |||
| probably guessed, you just need to use X<C<PERL6LIB>|p5 nutshell>: | |||
There was a problem hiding this comment.
Um, this looks weird. This is going to be indexed as what's to the right of the |; it might be better to use PERL6LIB,p5 nutshell. That creates a new category, so use whatever category is already been used there.
| @@ -16,7 +16,7 @@ page|https://github.com/rakudo/rakudo/wiki/dev-env-vars#moarvm>. | |||
|
|
|||
| =head2 Module loading | |||
|
|
|||
| X<|RAKUDOLIB>X<|PERL6LIB> | |||
| X<|RAKUDOLIB, environment variable>X<|PERL6LIB, environment variable> | |||
There was a problem hiding this comment.
Ditto here. Use only if there's already a category under that name.
|
Updated files pass 'make xtest' |
|
Closing as it's useless without search categories established. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #3199
I didn't check it is fine locally, please do before merge.