Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code highlighting using the correct scope name #3687

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Conversation

stoned
Copy link
Collaborator

@stoned stoned commented Nov 8, 2020

... when using a recent version of Raku/atom-language-perl6

Recently the scope name for Raku code has changed from 'source.perl6fe'
to 'source.raku' in the package atom-language-perl6.
See Raku/atom-language#96

We try to detect this change by testing for the presence of grammar file
'raku.cson', which beforehand was named 'perl6fe.cson'

Also, I suspect the script highlights/highlight-folder.coffee is not really used anymore. Perhaps it could be removed ?

... when using a recent version of Raku/atom-language-perl6

Recently the scope name for Raku code has changed from 'source.perl6fe'
to 'source.raku' in the package atom-language-perl6.
See Raku/atom-language#96

We try to detect this change by testing for the presence of grammar file
'raku.cson', which beforehand was named 'perl6fe.cson'
Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to test it, but it looks fine.

@JJ JJ merged commit 06f0ff5 into master Nov 8, 2020
@stoned stoned deleted the fix-highlights branch November 8, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants