Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image to 2019.03 #23

Closed
hoelzro opened this issue Apr 3, 2019 · 10 comments
Closed

Update image to 2019.03 #23

hoelzro opened this issue Apr 3, 2019 · 10 comments

Comments

@hoelzro
Copy link
Contributor

hoelzro commented Apr 3, 2019

The change is normally pretty trivial, but now that the docker build process uses GPG to verify the integrity of the tarball, and since the key used to generate the signature for 2019.03 differs from the one used for 2018.10, we need a way to verify that the key is authentic.

CC @jstuder-gh

@tianon
Copy link
Contributor

tianon commented Apr 3, 2019

It would appear that rakudo/star#124 (comment) is referencing this new key but doesn't include a fingerprint (or even keyid). 😕

Maybe the release fingerprint is something they'd be willing to add to the website so users can verify it easily as well as distributors?

@hankache
Copy link

hankache commented Apr 3, 2019

@hoelzro @tianon Hi. I signed the tarball. Is there anything I could do to make your life easier?

@tianon
Copy link
Contributor

tianon commented Apr 3, 2019

I figured you did but didn't want to be rude and @ you directly! 😅

It would be really awesome to publish the PGP key full fingerprint somewhere like the website (accessible via gpg --fingerprint on a system which has the public key, although I'm guessing you already know that 😅).

@hankache
Copy link

hankache commented Apr 3, 2019

@tianon I am not really sure what I should do 😅 but if you walk me through the steps I'll make them.
Thanks :)

@hankache
Copy link

hankache commented Apr 3, 2019

@tianon
Copy link
Contributor

tianon commented Apr 3, 2019

Oh nice, yeah, I'd recommend publishing 7A6C 9EB8 809C FEAF 0ED4 E09F 18C4 38E6 FF24 326D somewhere on the website as a known "release signer" (and @hoelzro that's the fingerprint you'll need to do the bump) so folks can both know what key to fetch and can easily verify that the Dockerfile here is consuming a known-published key from "the perl6 project", if that makes sense.

It would probably also make sense to include the old signing key for posterity's sake.

This is one place the PHP project really shines: https://www.php.net/downloads.php (see "GPG Keys" down on that page where they publish the full fingerprint for each release's "release team" members so downloads can be verified appropriately). They've also got https://www.php.net/gpg-keys.php for folks looking to verify even older releases, although I don't think you necessarily need to go to that extent. 😅

@AlexDaniel
Copy link
Member

There is a similar issue in rakudo.

@kawaii, @stmuk.

jstuder-gh added a commit to jstuder-gh/docker that referenced this issue Apr 6, 2019
This updates the Rakudo Star version to 2019.03 from 2018.10.

The maintainer for Rakudo Star changed between 2018.10 and 2019.03 so
the existing fingerprint used to retrieve the key and verify the tarball
is not valid for the new release. Updating to include the new
fingerprint along with the previous one; the old one will be used if the
user sets the "rakudo_version" arg to a release prior to 2019.03 when
building.

See [Github Issue Raku#23](Raku#23)
@jstuder-gh
Copy link
Contributor

Hey @hoelzro, @tianon, @hankache, I added a commit updating the version and including the new fingerprint. I've submitted a PR for it here.

I'm not sure what I submitted is the the best way to go about it (it's got an ugly bit of shell scripting to select between the old and new fingerprints depending on the rakudo_version), but if you guys think it's acceptable, feel free to merge :)

@tianon
Copy link
Contributor

tianon commented Jun 13, 2019

This was fixed by #24, right?

@jstuder-gh
Copy link
Contributor

Yes this was fixed and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants